Use expected ig-data path even when it doesn't exist on the filesystem#489
Merged
Use expected ig-data path even when it doesn't exist on the filesystem#489
Conversation
The IGExporter expects a path to be passed in, even if the path does not exist on the file system. If it receives null, it throws. Fix app.ts to never pass in a null path to the IGExporter. Since we only get the path in one place, and since it is now a single line of code, we no longer have need for a separate getIgDataPath function.
Member
Author
|
BTW -- couldn't easily write a test since we don't currently have a framework/harness for testing app.ts. But... reproduce the error by running SUSHI 0.13.0 on a FSH Tank with no ig-data folder. It will fail. Then run this branch on the same FSH Tank. It will succeed. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #488
The IGExporter expects a path to be passed in, even if the path does not exist on the file system. If it receives null, it throws. Fix app.ts to never pass in a null path to the IGExporter.
Since we only get the path in one place, and since it is now a single line of code, we no longer have need for a separate getIgDataPath function.