Log dependencies individually when extracted from IG#669
Merged
Conversation
When a configuration is extracted from an ImplementationGuide resource, info messages are logged for the elements of the configuration. The dependencies array may have many elements. To avoid an overly-long message, each element of the array is logged separately.
mint-thompson
requested review from
cmoesel,
jafeltra,
julianxcarter and
ngfreiter
Any array element in a configuration that is extracted from an ImplementationGuide resource is logged the same way. Currently, these are the dependencies and fhirVersion elements.
ngfreiter
approved these changes
Nov 16, 2020
Contributor
ngfreiter
left a comment
ngfreiter
left a comment
There was a problem hiding this comment.
This looks good to me!
cmoesel
approved these changes
Nov 16, 2020
Member
cmoesel
left a comment
cmoesel
left a comment
There was a problem hiding this comment.
Perfect! And I confirmed that it now plays nicely w/ the IG Publisher, even w/ the project that previously caused issues in the publisher. Thank you, @mint-thompson!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a configuration is extracted from an ImplementationGuide resource, info messages are logged for the elements of the configuration. The dependencies array may have many elements. To avoid an overly-long message, each element of the array is logged separately.