Conversation
ngfreiter
requested review from
cmoesel,
jafeltra,
julianxcarter and
mint-thompson
Member
@ngfreiter -- Can we meet to discuss this? I fear this quest may be more complicated than you realize and would like to discuss the many implications therein. |
Contributor
Author
|
Mission failed. I'll be back. But for now I think 46137b5 should fix another bug. |
cmoesel
approved these changes
Mar 16, 2021
Member
cmoesel
left a comment
cmoesel
left a comment
There was a problem hiding this comment.
This looks great, @ngfreiter. Sorry you didn't capture the smallest PR this time. But maybe next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a typo in one of our errors. I jumped on this in my ongoing quest for smallest PR. I don't know how you beat 1 single character removal.