Merged
Conversation
This required changing how we detect other comma-delimited lists too since the ANTLR parser errors changed when we removed the COMMA_DELIMITED_X tokens.
Member
Author
|
Also... hurray for deleting code! |
mint-thompson
approved these changes
May 21, 2021
jafeltra
approved these changes
May 24, 2021
Collaborator
jafeltra
left a comment
There was a problem hiding this comment.
Looks great! I got the expected errors and the tests look updated to me!
I haven't run the regression script on this yet, but I can if we'd like before officially merging.
Member
Author
|
I ran the regression:all script and there were (surprisingly) no regressions. I guess our warnings about deprecated syntax worked! So... I am going to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support for formerly deprecated syntax features, including:
Mixins:keywordunitskeyword,path separator in flag rules (replaced byand),concept separator in value set rules (replaced byand)|type separator in references (replaced byor)These have all been removed from the formal grammar (to keep it nice and tidy). When ANTLR produces syntax errors, SUSHI analyzes them to produce a friendly error message.
Tests have been updated accordingly, but you can also test this manually with the following FSH: