Elements can be constrained with canonicals that contain versions#898
Merged
mint-thompson merged 3 commits intomasterfrom Aug 11, 2021
Merged
Elements can be constrained with canonicals that contain versions#898mint-thompson merged 3 commits intomasterfrom
mint-thompson merged 3 commits intomasterfrom
Conversation
A version can be included as part of a canonical type in an OnlyRule. This version is included in the target profiles of the type.
If an element with a canonical type is constrained with versioned types, it is still possible to assign a value to that element as long as it matches a target profile. The version provided in the constraint is not checked when this value is assigned.
mint-thompson
requested review from
cmoesel,
jafeltra,
julianxcarter and
ngfreiter
julianxcarter
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #863 and completes task CIMPL-791.
The version provided with the canonical type on the type constraint is appended to the
targetProfileon the element. When values are assigned to the element, the version is not checked. For example, if an element is constrained toCanonical(Patient|4.0.1), then anyPatientinstance can have its canonical assigned to the element, regardless of the version of thePatientprofile it is an instance of.Basically: authors are allowed to specify a version in the type constraint, and that version will appear in the FHIR resource, but the version does not affect SUSHI's type checks.