Don't use HTTP HEAD to determine package availability#975
Merged
Conversation
The packages.fhir.org server no longer allows HTTP HEAD requests. Since SUSHI used HTTP HEAD to determine if a package was available on packages.fhir.org, this is obviously a problem. Now we will just attempt the download on packages.fhir.org first and if there is an error, redo it on packages2.fhir.org.
mint-thompson
approved these changes
Dec 10, 2021
julianxcarter
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages.fhir.org server no longer allows HTTP HEAD requests. Since SUSHI used HTTP HEAD to determine if a package was available on packages.fhir.org, this is obviously a problem.
Now we will just attempt the download on packages.fhir.org first and if there is an error, redo it on packages2.fhir.org. In the future, however, we should use the version-listing capability that is now part of the API (see zulip). But.. this will suffice for now and causes less churn in the code while @jafeltra continues to refactor this code into a new module.
To test, create a SUSHI project with this dependency:
On master, it will fail to download it. On this branch, it will succeed.