Conversation
Closed
alvarobernal2412
requested changes
Nov 17, 2024
Contributor
alvarobernal2412
left a comment
There was a problem hiding this comment.
It looks very good, however, there are still a couple of things to be polished up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request includes significant changes to migrate the project from a Node.js-based setup to a Rust-based setup. The most important changes include modifications to the Docker setup, updates to the project dependencies and build commands, and adjustments to the configuration files to align with the new Rust environment.
Migration to Rust:
Dockerfile: Replaced the Node.js base image and setup with a Rust-based build process, including a multi-stage Docker build for the Rust project.README.md: Updated the installation, development, and production instructions to use Rust commands (cargo) instead of Node.js commands (npm).Configuration Updates:
.github/workflows/docker-deploy.yml: Updated the Docker image names toapi-gatewayto reflect the new project name.config.yaml.example: Renamed and updated the configuration file to use0.0.0.0as the API gateway URL.Docker and Environment Setup:
docker-compose.yml: Removed the MongoDB service and updated the service name and configuration for the newapi-gateway.Code Adjustments:
src/config/parser.rs:load_confignow reads from a preloaded&strvalue representing the contents ofconfig.yamlto allow reading the configuration in production.src/main.rs: Modified the main function to load the configuration from an included string instead of a file.