Skip to content

Feature/5 dockerize#12

Merged
TunixR merged 4 commits intomainfrom
feature/5-dockerize
Nov 17, 2024
Merged

Feature/5 dockerize#12
TunixR merged 4 commits intomainfrom
feature/5-dockerize

Conversation

@TunixR
Copy link
Copy Markdown
Contributor

@TunixR TunixR commented Nov 17, 2024

This pull request includes significant changes to migrate the project from a Node.js-based setup to a Rust-based setup. The most important changes include modifications to the Docker setup, updates to the project dependencies and build commands, and adjustments to the configuration files to align with the new Rust environment.

Migration to Rust:

  • Dockerfile: Replaced the Node.js base image and setup with a Rust-based build process, including a multi-stage Docker build for the Rust project.
  • README.md: Updated the installation, development, and production instructions to use Rust commands (cargo) instead of Node.js commands (npm).

Configuration Updates:

Docker and Environment Setup:

  • docker-compose.yml: Removed the MongoDB service and updated the service name and configuration for the new api-gateway.

Code Adjustments:

  • src/config/parser.rs: load_config now reads from a preloaded &str value representing the contents of config.yaml to allow reading the configuration in production.
  • src/main.rs: Modified the main function to load the configuration from an included string instead of a file.

@TunixR TunixR self-assigned this Nov 17, 2024
@TunixR TunixR requested a review from adrrf as a code owner November 17, 2024 12:52
@TunixR TunixR linked an issue Nov 17, 2024 that may be closed by this pull request
@github-actions github-actions Bot added 📝 Documentation Improvements or additions to documentation ⚙️ Configuration Indicates the scope is related to the configuration 🚀 CI/CD Indicates the change is related to CI/CD workflows 🐳 Build 😎 size/m Pull request size M labels Nov 17, 2024
Copy link
Copy Markdown
Contributor

@alvarobernal2412 alvarobernal2412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good, however, there are still a couple of things to be polished up

Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Copy link
Copy Markdown
Contributor

@adrrf adrrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Copy Markdown
Contributor

@alvarobernal2412 alvarobernal2412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James Franco Thumbs Up

@TunixR TunixR merged commit 01b58f3 into main Nov 17, 2024
@TunixR TunixR deleted the feature/5-dockerize branch November 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 CI/CD Indicates the change is related to CI/CD workflows ⚙️ Configuration Indicates the scope is related to the configuration 📝 Documentation Improvements or additions to documentation 😎 size/m Pull request size M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Dockerize

3 participants