Skip to content

Conversation

@cyjseagull
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jul 14, 2020

Warnings are found on analyzing the commit 462b3a0.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

import java.util.Objects;
import org.fisco.bcos.sdk.crypto.CryptoNativeResult;

public abstract class CryptoKeyPair {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead to identify a "CryptoKeyPair" by yourself, you can consider use 'java.security.KeyPair'.
The 'org.bouncycastle' package can help you read KeyPair from PEM file and P12 file. If you would like to use this function, maybe you can consider to use 'java.security.KeyPair' directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will fix it in the next PR.

@cyjseagull cyjseagull requested a review from dalaocu July 15, 2020 02:47
1. add crypto interface and the basic implementation

2. add libffi_java_sdk.dylib
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cyjseagull cyjseagull merged commit ad2f4de into FISCO-BCOS:dev Jul 15, 2020
cyjseagull added a commit that referenced this pull request Aug 11, 2020
1. add crypto interface and the basic implementation

2. add libffi_java_sdk.dylib
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
1. add crypto interface and the basic implementation

2. add libffi_java_sdk.dylib
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. add crypto interface and the basic implementation

2. add libffi_java_sdk.dylib
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. add crypto interface and the basic implementation

2. add libffi_java_sdk.dylib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants