Skip to content

Conversation

@MaggieNgWu
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Sep 18, 2020

Sider detected 4 warnings on analyzing the commit aaa64f2.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

@MaggieNgWu MaggieNgWu force-pushed the dev branch 2 times, most recently from 1fd7854 to d0df2b3 Compare September 18, 2020 09:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #111 into dev will increase coverage by 0.03%.
The diff coverage is 20.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #111      +/-   ##
============================================
+ Coverage     16.00%   16.03%   +0.03%     
  Complexity      793      793              
============================================
  Files           452      452              
  Lines         15284    15294      +10     
  Branches       1627     1629       +2     
============================================
+ Hits           2446     2453       +7     
- Misses        12597    12599       +2     
- Partials        241      242       +1     
Impacted Files Coverage Δ Complexity Δ
...fisco/bcos/sdk/demo/amop/perf/AmopMsgCallback.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/fisco/bcos/sdk/demo/amop/tool/AmopPublisher.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...sco/bcos/sdk/demo/amop/tool/AmopPublisherFile.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../bcos/sdk/demo/amop/tool/AmopPublisherPrivate.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...s/sdk/demo/amop/tool/AmopPublisherPrivateFile.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../fisco/bcos/sdk/demo/amop/tool/AmopSubscriber.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...bcos/sdk/demo/amop/tool/AmopSubscriberPrivate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...isco/bcos/sdk/demo/amop/tool/DemoAmopCallback.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/org/fisco/bcos/sdk/amop/AmopCallback.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/org/fisco/bcos/sdk/amop/AmopImp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f325a35...aaa64f2. Read the comment docs.

@cyjseagull cyjseagull merged commit 6f1d5c6 into FISCO-BCOS:dev Sep 18, 2020
MaggieNgWu added a commit that referenced this pull request Sep 27, 2020
Co-authored-by: cyjseagull <yujiechen_hust@163.com>
cyjseagull added a commit that referenced this pull request Oct 12, 2020
Co-authored-by: cyjseagull <yujiechen_hust@163.com>
cyjseagull added a commit that referenced this pull request Oct 12, 2020
Co-authored-by: cyjseagull <yujiechen_hust@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants