Skip to content

Conversation

@cyjseagull
Copy link
Member

  1. update build.gradle to unify the version

  2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

  3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair

@ghost
Copy link

ghost commented Sep 23, 2020

Sider detected 4 warnings on analyzing the commit 9f45f8a.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev-jar@ed59ac1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             dev-jar     #122   +/-   ##
==========================================
  Coverage           ?   23.79%           
  Complexity         ?      166           
==========================================
  Files              ?       76           
  Lines              ?     2807           
  Branches           ?      288           
==========================================
  Hits               ?      668           
  Misses             ?     2041           
  Partials           ?       98           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed59ac1...acf2c88. Read the comment docs.

1. update build.gradle to unify the version

2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cyjseagull cyjseagull merged commit 333d3f6 into FISCO-BCOS:dev-jar Sep 23, 2020
cyjseagull added a commit to cyjseagull/java-sdk that referenced this pull request Sep 23, 2020
1. update build.gradle to unify the version

2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair
cyjseagull added a commit that referenced this pull request Sep 23, 2020
1. update build.gradle to unify the version

2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
1. update build.gradle to unify the version

2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. update build.gradle to unify the version

2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. update build.gradle to unify the version

2. rename PEMManager to PEMKeyStore, P12Manager to P12KeyStore

3. modify cryptoInterface param when deploying/call contracts to CryptoKeyPair
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants