Skip to content

Conversation

@cyjseagull
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Sep 23, 2020

Sider detected 4 warnings on analyzing the commit ee83518.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #129 into dev will increase coverage by 7.92%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #129      +/-   ##
============================================
+ Coverage     16.03%   23.95%   +7.92%     
+ Complexity      793      167     -626     
============================================
  Files           452       76     -376     
  Lines         15296     2805   -12491     
  Branches       1629      288    -1341     
============================================
- Hits           2453      672    -1781     
+ Misses        12601     2036   -10565     
+ Partials        242       97     -145     
Impacted Files Coverage Δ Complexity Δ
...op/src/main/java/org/fisco/bcos/sdk/amop/Amop.java 66.66% <ø> (ø) 1.00 <0.00> (?)
...ain/java/org/fisco/bcos/sdk/amop/AmopCallback.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...src/main/java/org/fisco/bcos/sdk/amop/AmopImp.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/java/org/fisco/bcos/sdk/amop/AmopMsgOut.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...g/fisco/bcos/sdk/amop/exception/AmopException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../java/org/fisco/bcos/sdk/amop/topic/AmopMsgIn.java 80.95% <ø> (ø) 10.00 <0.00> (?)
...a/org/fisco/bcos/sdk/amop/topic/AmopRespError.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...g/fisco/bcos/sdk/amop/topic/RequestVerifyData.java 100.00% <ø> (ø) 7.00 <0.00> (?)
.../java/org/fisco/bcos/sdk/amop/topic/TopicType.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...g/fisco/bcos/sdk/amop/topic/UpdateTopicStatus.java 100.00% <ø> (ø) 7.00 <0.00> (?)
... and 256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b545a50...ee83518. Read the comment docs.

@cyjseagull cyjseagull merged commit dfd0962 into FISCO-BCOS:dev Sep 24, 2020
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
cyjseagull added a commit that referenced this pull request Oct 12, 2020
cyjseagull added a commit that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants