Skip to content

Conversation

@cyjseagull
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jul 16, 2020

Warnings are found on analyzing the commit 326145a.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@cyjseagull cyjseagull requested review from MaggieNgWu and ywy2090 July 16, 2020 07:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@MaggieNgWu MaggieNgWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this sentence this.privateKey = ((BCECPrivateKey) keyPair.getPrivate()).getD(); is right when use sm2 algorithm.

@cyjseagull cyjseagull merged commit 895a74e into FISCO-BCOS:dev Jul 16, 2020
cyjseagull added a commit that referenced this pull request Aug 11, 2020
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
cyjseagull added a commit that referenced this pull request Oct 12, 2020
cyjseagull added a commit that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants