Skip to content

cache ArrayIndexOutOfBoundsException caused by concurrrent modify nod… #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2020
Merged

cache ArrayIndexOutOfBoundsException caused by concurrrent modify nod… #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions sdk-service/src/main/java/org/fisco/bcos/sdk/service/GroupServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,21 @@ public BigInteger getLatestBlockNumber() {

@Override
public String getNodeWithTheLatestBlockNumber() {
// the case that the sdk is allowed to access all the connected node, select the first
// connected node to send the request
if (nodeWithLatestBlockNumber.size() > 0) {
int random = (int) (Math.random() * (nodeWithLatestBlockNumber.size()));
return nodeWithLatestBlockNumber.get(random);
try {
// the case that the sdk is allowed to access all the connected node, select the first
// connected node to send the request
if (nodeWithLatestBlockNumber.size() > 0) {
// Note: when the nodeWithLatestBlockNumber modified, and the random value
// calculated after the modification, and the nodeWithLatestBlockNumber.get is
// called after the modification, this function will throw
// ArrayIndexOutOfBoundsException
int random = (int) (Math.random() * (nodeWithLatestBlockNumber.size()));
return nodeWithLatestBlockNumber.get(random);
}
} catch (Exception e) {
logger.error(
"getNodeWithTheLatestBlockNumber for {}, select the node to send message randomly",
e.getMessage());
}
// select the first element
if (!groupNodeSet.isEmpty()) {
Expand Down