Skip to content

Conversation

@cyjseagull
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost
Copy link

ghost commented Sep 24, 2020

Sider detected 4 warnings on analyzing the commit 9a393ba.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

@codecov-commenter
Copy link

Codecov Report

Merging #136 into dev will increase coverage by 0.92%.
The diff coverage is 35.06%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #136      +/-   ##
============================================
+ Coverage     16.03%   16.96%   +0.92%     
+ Complexity      793      648     -145     
============================================
  Files           452      411      -41     
  Lines         15296    12159    -3137     
  Branches       1629     1413     -216     
============================================
- Hits           2453     2063     -390     
+ Misses        12601     9877    -2724     
+ Partials        242      219      -23     
Impacted Files Coverage Δ Complexity Δ
...java/org/fisco/bcos/sdk/abi/ABICodecException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...src/main/java/org/fisco/bcos/sdk/abi/Constant.java 75.00% <ø> (ø) 1.00 <0.00> (?)
...main/java/org/fisco/bcos/sdk/abi/EventEncoder.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/java/org/fisco/bcos/sdk/abi/EventValues.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../org/fisco/bcos/sdk/abi/FunctionReturnDecoder.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../main/java/org/fisco/bcos/sdk/abi/TypeDecoder.java 40.67% <ø> (ø) 17.00 <0.00> (?)
.../main/java/org/fisco/bcos/sdk/abi/TypeEncoder.java 51.64% <ø> (ø) 18.00 <0.00> (?)
...a/org/fisco/bcos/sdk/abi/TypeMappingException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ain/java/org/fisco/bcos/sdk/abi/TypeReference.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...bi/src/main/java/org/fisco/bcos/sdk/abi/Utils.java 0.00% <ø> (ø) 0.00 <0.00> (?)
... and 611 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1919c90...9a393ba. Read the comment docs.

@cyjseagull cyjseagull merged commit bb0cf25 into FISCO-BCOS:dev Sep 24, 2020
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
cyjseagull added a commit that referenced this pull request Oct 12, 2020
cyjseagull added a commit that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants