add p12/pem support && add getAddress #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warnings are found on analyzing the commit 252a4ea. 4 warnings: We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure If you are struggling with these errors or warnings, feel free to ask us via chat. 💬 |
ghost
reviewed
Jul 16, 2020
| /** | ||
| * get the address according to the public key | ||
| * | ||
| * @return: the address calcualted from the publicKey |
There was a problem hiding this comment.
[Misspell] "calcualted" is a misspelling of "calculated" (view)
| Rule | Correct | Incorrect |
|---|---|---|
calculated |
calculated | calcualted |
You can close this issue if no need to fix it. Learn more.
MaggieNgWu
approved these changes
Jul 17, 2020
ywy2090
approved these changes
Jul 17, 2020
MaggieNgWu
approved these changes
Jul 17, 2020
1. support load key-pair from the p12/pem files 2. add getAddress to CryptoKeyPair 3. Place excepito in the corresponding module
|
Kudos, SonarCloud Quality Gate passed!
|
cyjseagull
added a commit
that referenced
this pull request
Aug 11, 2020
1. support load key-pair from the p12/pem files 2. add getAddress to CryptoKeyPair 3. Place excepito in the corresponding module
MaggieNgWu
pushed a commit
that referenced
this pull request
Sep 27, 2020
1. support load key-pair from the p12/pem files 2. add getAddress to CryptoKeyPair 3. Place excepito in the corresponding module
cyjseagull
added a commit
that referenced
this pull request
Oct 12, 2020
1. support load key-pair from the p12/pem files 2. add getAddress to CryptoKeyPair 3. Place excepito in the corresponding module
cyjseagull
added a commit
that referenced
this pull request
Oct 12, 2020
1. support load key-pair from the p12/pem files 2. add getAddress to CryptoKeyPair 3. Place excepito in the corresponding module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.