Skip to content

Conversation

@dalaocu
Copy link
Collaborator

@dalaocu dalaocu commented Jul 20, 2020

No description provided.

@ghost
Copy link

ghost commented Jul 20, 2020

Warnings are found on analyzing the commit 0ba06c0.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

* @data Jul 17, 2020 3:24:40 PM
*
*/
public class ContractLoader {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ContractLoader class should be in the module of Contract?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's based on the module of Contract

dalaocu added 2 commits July 20, 2020 14:36
Constructor -> SolidityConstructor
Function -> SolidityFunction
@dalaocu dalaocu requested a review from MaggieNgWu July 20, 2020 06:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cyjseagull cyjseagull merged commit 67c2583 into FISCO-BCOS:dev Jul 20, 2020
cyjseagull added a commit that referenced this pull request Aug 11, 2020
* add interface of tx module

* rename ambiguous class name

Constructor -> SolidityConstructor
Function -> SolidityFunction


Co-authored-by: cyjseagull <yujiechen_hust@163.com>
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
* add interface of tx module

* rename ambiguous class name

Constructor -> SolidityConstructor
Function -> SolidityFunction


Co-authored-by: cyjseagull <yujiechen_hust@163.com>
cyjseagull added a commit that referenced this pull request Oct 12, 2020
* add interface of tx module

* rename ambiguous class name

Constructor -> SolidityConstructor
Function -> SolidityFunction


Co-authored-by: cyjseagull <yujiechen_hust@163.com>
cyjseagull added a commit that referenced this pull request Oct 12, 2020
* add interface of tx module

* rename ambiguous class name

Constructor -> SolidityConstructor
Function -> SolidityFunction


Co-authored-by: cyjseagull <yujiechen_hust@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants