Skip to content

Conversation

@MaggieNgWu
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Oct 21, 2020

Sider detected 5 warnings on analyzing the commit e26d0b4.

We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring sider.yml, turning off unused tools, and so on.

If you have problems or questions still, feel free to ask us via chat. 💬


You can turn off this notification if you don't want to receive it from now on.

@MaggieNgWu MaggieNgWu changed the base branch from master to dev October 21, 2020 13:37
@MaggieNgWu MaggieNgWu force-pushed the dev branch 3 times, most recently from 6ff525d to 3b7f112 Compare October 22, 2020 03:35
@codecov-io
Copy link

Codecov Report

Merging #172 into dev will increase coverage by 1.09%.
The diff coverage is 22.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #172      +/-   ##
============================================
+ Coverage     16.03%   17.12%   +1.09%     
+ Complexity      793      662     -131     
============================================
  Files           452      413      -39     
  Lines         15296    12407    -2889     
  Branches       1629     1443     -186     
============================================
- Hits           2453     2125     -328     
+ Misses        12601    10047    -2554     
+ Partials        242      235       -7     
Impacted Files Coverage Δ Complexity Δ
...java/org/fisco/bcos/sdk/abi/ABICodecException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...src/main/java/org/fisco/bcos/sdk/abi/Constant.java 75.00% <ø> (ø) 1.00 <0.00> (?)
...main/java/org/fisco/bcos/sdk/abi/EventEncoder.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/java/org/fisco/bcos/sdk/abi/EventValues.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../org/fisco/bcos/sdk/abi/FunctionReturnDecoder.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../main/java/org/fisco/bcos/sdk/abi/TypeDecoder.java 40.67% <ø> (ø) 17.00 <0.00> (?)
.../main/java/org/fisco/bcos/sdk/abi/TypeEncoder.java 51.64% <ø> (ø) 18.00 <0.00> (?)
...a/org/fisco/bcos/sdk/abi/TypeMappingException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ain/java/org/fisco/bcos/sdk/abi/TypeReference.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...bi/src/main/java/org/fisco/bcos/sdk/abi/Utils.java 0.00% <ø> (ø) 0.00 <0.00> (?)
... and 624 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d58ad...068f60a. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MaggieNgWu MaggieNgWu merged commit 576f713 into FISCO-BCOS:dev Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants