Skip to content

Conversation

@cyjseagull
Copy link
Member

  1. Channel module adds synchronous sending interface && Move client/response and client/request to client/protocol directory

  2. add coverage

@ghost
Copy link

ghost commented Jul 20, 2020

Warnings are found on analyzing the commit a23d1fe.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@67c2583). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #18   +/-   ##
======================================
  Coverage       ?   17.29%           
  Complexity     ?      119           
======================================
  Files          ?      121           
  Lines          ?     1810           
  Branches       ?      190           
======================================
  Hits           ?      313           
  Misses         ?     1462           
  Partials       ?       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c2583...a23d1fe. Read the comment docs.

1. Channel module adds synchronous sending interface && Move client/response and client/request to client/protocol directory

2. add coverage statistic to ci
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cyjseagull cyjseagull merged commit bee424c into FISCO-BCOS:dev Jul 20, 2020
cyjseagull added a commit that referenced this pull request Aug 11, 2020
1. Channel module adds synchronous sending interface && Move client/response and client/request to client/protocol directory

2. add coverage statistic to ci
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
1. Channel module adds synchronous sending interface && Move client/response and client/request to client/protocol directory

2. add coverage statistic to ci
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. Channel module adds synchronous sending interface && Move client/response and client/request to client/protocol directory

2. add coverage statistic to ci
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. Channel module adds synchronous sending interface && Move client/response and client/request to client/protocol directory

2. add coverage statistic to ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants