Skip to content

Conversation

@cyjseagull
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jul 20, 2020

Warnings are found on analyzing the commit 82da39a.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2020

Codecov Report

Merging #19 into dev will increase coverage by 3.16%.
The diff coverage is 15.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #19      +/-   ##
============================================
+ Coverage     17.29%   20.45%   +3.16%     
- Complexity      119      154      +35     
============================================
  Files           121      125       +4     
  Lines          1810     2229     +419     
  Branches        190      212      +22     
============================================
+ Hits            313      456     +143     
- Misses         1462     1716     +254     
- Partials         35       57      +22     
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/fisco/bcos/sdk/client/ClientImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/org/fisco/bcos/sdk/client/JsonRpcService.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...co/bcos/sdk/client/exceptions/ClientException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...dk/client/protocol/request/GenerateGroupParam.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...o/bcos/sdk/client/protocol/response/BcosBlock.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../sdk/client/protocol/response/BcosTransaction.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ient/protocol/response/BcosTransactionReceipt.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...o/bcos/sdk/client/protocol/response/BlockHash.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bcos/sdk/client/protocol/response/BlockNumber.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../fisco/bcos/sdk/client/protocol/response/Call.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee424c...82da39a. Read the comment docs.

1. implement Client interface

2. implement BcosBlockHeader Response

3. add ut for Message and BcosBlockHeader
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cyjseagull cyjseagull merged commit 94c2f53 into FISCO-BCOS:dev Jul 21, 2020
cyjseagull added a commit that referenced this pull request Aug 11, 2020
1. implement Client interface

2. implement BcosBlockHeader Response

3. add ut for Message and BcosBlockHeader
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
1. implement Client interface

2. implement BcosBlockHeader Response

3. add ut for Message and BcosBlockHeader
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. implement Client interface

2. implement BcosBlockHeader Response

3. add ut for Message and BcosBlockHeader
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. implement Client interface

2. implement BcosBlockHeader Response

3. add ut for Message and BcosBlockHeader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants