Skip to content

Conversation

@cyjseagull
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Jul 22, 2020

Warnings are found on analyzing the commit e405a99.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #26 into dev will increase coverage by 1.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #26      +/-   ##
============================================
+ Coverage     26.16%   27.37%   +1.20%     
  Complexity      287      287              
============================================
  Files           137      135       -2     
  Lines          3287     3142     -145     
  Branches        434      392      -42     
============================================
  Hits            860      860              
+ Misses         2311     2166     -145     
  Partials        116      116              
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/fisco/bcos/sdk/client/ClientImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/org/fisco/bcos/sdk/client/JsonRpcService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ient/protocol/response/BcosTransactionReceipt.java 28.57% <ø> (ø) 2.00 <0.00> (ø)
...protocol/response/TransactionReceiptWithProof.java 56.25% <ø> (ø) 2.00 <0.00> (ø)
...client/protocol/response/TransactionWithProof.java 56.25% <ø> (ø) 2.00 <0.00> (ø)
...java/org/fisco/bcos/sdk/model/MerkleProofUnit.java 53.84% <ø> (ø) 5.00 <0.00> (?)
...a/org/fisco/bcos/sdk/model/TransactionReceipt.java 50.00% <ø> (ø) 30.00 <0.00> (?)
...saction/core/impl/executor/TransactionDecoder.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...nsaction/core/impl/executor/TransactionPusher.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...dk/transaction/domain/dto/TransactionResponse.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c0c00...e405a99. Read the comment docs.

@cyjseagull cyjseagull requested a review from dalaocu July 23, 2020 12:35
2. Place the files that both the transaction and client modules depend on in the model module

3. When gradlew build is executed, integrationTest is not run
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cyjseagull cyjseagull merged commit acad32f into FISCO-BCOS:dev Jul 23, 2020
cyjseagull added a commit that referenced this pull request Aug 11, 2020
1. add groupManager related interfaces 

2. Place the files that both the transaction and client modules depend on in the model module

3. When gradlew build is executed, integrationTest is not run
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
1. add groupManager related interfaces 

2. Place the files that both the transaction and client modules depend on in the model module

3. When gradlew build is executed, integrationTest is not run
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. add groupManager related interfaces 

2. Place the files that both the transaction and client modules depend on in the model module

3. When gradlew build is executed, integrationTest is not run
cyjseagull added a commit that referenced this pull request Oct 12, 2020
1. add groupManager related interfaces 

2. Place the files that both the transaction and client modules depend on in the model module

3. When gradlew build is executed, integrationTest is not run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants