add event subscribe module and implement subscribe function #27
Conversation
|
Warnings are found on analyzing the commit a2daf8e. 4 warnings: We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure If you are struggling with these errors or warnings, feel free to ask us via chat. 💬 |
Codecov Report
@@ Coverage Diff @@
## dev #27 +/- ##
============================================
- Coverage 24.40% 21.76% -2.64%
- Complexity 274 279 +5
============================================
Files 143 154 +11
Lines 3385 3850 +465
Branches 394 445 +51
============================================
+ Hits 826 838 +12
- Misses 2443 2896 +453
Partials 116 116
Continue to review full report at Codecov.
|
MaggieNgWu
force-pushed
the
dev
branch
2 times, most recently
from
3775c2d to
30f4cb6
Compare
| public class EventLog {} | ||
| package org.fisco.bcos.sdk.utils; | ||
|
|
||
| public class Address { |
There was a problem hiding this comment.
utils包下面建议统一改为XXUtils或XXUtil后缀，便于和基本数据结构进行区分。
| } | ||
|
|
||
| private BigInteger lastBlockNumber = null; | ||
| private long logCount = 0; |
There was a problem hiding this comment.
这个变量类型是不是改成BigInteger会更一致点？
| private BigInteger lastBlockNumber = null; | ||
| private long logCount = 0; | ||
|
|
||
| public abstract void onReceiveLog(int status, List<EventLog> logs); |
| } | ||
| } | ||
| } catch (JsonProcessingException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
建议打下错误日志？ e.printStackTrace();这种一般在实际开发中被禁止
| } | ||
|
|
||
| @Override | ||
| public void onDisconnect(ChannelHandlerContext ctx) {} |
| } | ||
|
|
||
| @Override | ||
| public void onConnect(ChannelHandlerContext ctx) {} |
MaggieNgWu
force-pushed
the
dev
branch
3 times, most recently
from
10a595c to
f7ae454
Compare
| * @param filterID | ||
| */ | ||
| void unsubscribeEvent(String filterId); | ||
| void unsubscribeEvent(String filterID); |
There was a problem hiding this comment.
应该是filterId吧，和groupId一样保持命名风格
|
Kudos, SonarCloud Quality Gate passed!
|
1. add event subscribe module and implement subscribe function 2. rename utils 3. add decoder of EventLog
1. add event subscribe module and implement subscribe function 2. rename utils 3. add decoder of EventLog
1. add event subscribe module and implement subscribe function 2. rename utils 3. add decoder of EventLog
1. add event subscribe module and implement subscribe function 2. rename utils 3. add decoder of EventLog
5 participants
No description provided.