Skip to content

add timeout #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2020
Merged

add timeout #29

merged 3 commits into from
Jul 27, 2020

Conversation

@chaychen2005
Copy link
Contributor

@chaychen2005 chaychen2005 commented Jul 24, 2020

No description provided.

@ghost
Copy link

ghost commented Jul 24, 2020 •
edited by ghost
Loading

Warnings are found on analyzing the commit 63e5ad8.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020 •
edited
Loading

Codecov Report

Merging #29 into dev will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #29      +/-   ##
============================================
- Coverage     21.76%   21.62%   -0.15%     
  Complexity      279      279              
============================================
  Files           154      155       +1     
  Lines          3850     3876      +26     
  Branches        445      447       +2     
============================================
  Hits            838      838              
- Misses         2896     2922      +26     
  Partials        116      116
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/fisco/bcos/sdk/channel/Channel.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/org/fisco/bcos/sdk/channel/ChannelImp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../org/fisco/bcos/sdk/channel/ChannelMsgHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/org/fisco/bcos/sdk/channel/model/Options.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/org/fisco/bcos/sdk/client/JsonRpcService.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a34e3b...63e5ad8. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MaggieNgWu MaggieNgWu self-requested a review July 24, 2020 12:44
MaggieNgWu
MaggieNgWu approved these changes Jul 24, 2020
View reviewed changes
src/integration-test/java/org/fisco/bcos/sdk/channel/ChannelTest.java
TestMsgHandler testMsgHandler = new TestMsgHandler();
channel.addConnectHandler(testMsgHandler);
channel.addMessageHandler(MsgType.CHANNEL_RPC_REQUEST, testMsgHandler);
channel.addDisconnectHandler(testMsgHandler);
Copy link
Contributor

@MaggieNgWu MaggieNgWu Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add two interfaces "void start()" and "void stop()" in channel.

@chaychen2005 chaychen2005 merged commit 4f7d96e into FISCO-BCOS:dev Jul 27, 2020
cyjseagull pushed a commit that referenced this pull request Aug 11, 2020
@chaychen2005 @MaggieNgWu
add timeout (#29)
71b3800 
* add timeout

* channel integration-test

Co-authored-by: MaggieNgWu <hao.maggie.wu@gmail.com>
MaggieNgWu added a commit that referenced this pull request Sep 27, 2020
@chaychen2005 @MaggieNgWu
add timeout (#29)
cb90a68 
* add timeout

* channel integration-test

Co-authored-by: MaggieNgWu <hao.maggie.wu@gmail.com>
cyjseagull pushed a commit that referenced this pull request Oct 12, 2020
@chaychen2005 @MaggieNgWu @cyjseagull
add timeout (#29)
525bd85 
* add timeout

* channel integration-test

Co-authored-by: MaggieNgWu <hao.maggie.wu@gmail.com>
cyjseagull pushed a commit that referenced this pull request Oct 12, 2020
@chaychen2005 @MaggieNgWu @cyjseagull
add timeout (#29)
1fd9687 
* add timeout

* channel integration-test

Co-authored-by: MaggieNgWu <hao.maggie.wu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywy2090 ywy2090 ywy2090 approved these changes

+1 more reviewer

@MaggieNgWu MaggieNgWu MaggieNgWu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chaychen2005 @codecov-commenter @ywy2090 @MaggieNgWu