-
Notifications
You must be signed in to change notification settings - Fork 61
Add java-sdk compilation related dependencies, add ci #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warnings are found on analyzing the commit be57edb. 5 warnings: We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure If you are struggling with these errors or warnings, feel free to ask us via chat. 💬 |
| check_commit_message() | ||
| { | ||
| if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then | ||
| local skip=$(curl -s https://api.github.com/repos/FISCO-BCOS/java-sdk/pulls/${TRAVIS_PULL_REQUEST} | grep "title\"" | grep "${skip_check_words}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ShellCheck] Declare and assign separately to avoid masking return values. (view)
| Rule | Severity | Code |
|---|---|---|
SC2155 |
warning |
2155 |
References:
You can close this issue if no need to fix it. Learn more.
| check_commit_message() | ||
| { | ||
| if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then | ||
| local skip=$(curl -s https://api.github.com/repos/FISCO-BCOS/java-sdk/pulls/${TRAVIS_PULL_REQUEST} | grep "title\"" | grep "${skip_check_words}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ShellCheck] Double quote to prevent globbing and word splitting. (view)
| Rule | Severity | Code |
|---|---|---|
SC2086 |
info |
2086 |
References:
You can close this issue if no need to fix it. Learn more.
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.