Skip to content

Conversation

@chaychen2005
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Jul 29, 2020

Warnings are found on analyzing the commit d604727.

4 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

❌ Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.25%. Comparing base (e7343ba) to head (d604727).
⚠️ Report is 738 commits behind head on dev.

Files with missing lines Patch % Lines
...in/java/org/fisco/bcos/sdk/channel/ChannelImp.java 0.00% 45 Missing ⚠️
.../org/fisco/bcos/sdk/channel/ChannelMsgHandler.java 0.00% 7 Missing ⚠️
...co/bcos/sdk/channel/model/ChannelMessageError.java 0.00% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (20.25%) is below the target coverage (30.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev      #34      +/-   ##
============================================
- Coverage     20.45%   20.25%   -0.21%     
  Complexity      287      287              
============================================
  Files           163      163              
  Lines          4234     4276      +42     
  Branches        476      479       +3     
============================================
  Hits            866      866              
- Misses         3248     3290      +42     
  Partials        120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

try{
channel.start();
sendMessage();
Thread.sleep(10000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid use Thread.sleep, it makes the test takes long time.

@chaychen2005 chaychen2005 merged commit 0dbd8af into FISCO-BCOS:dev Jul 29, 2020
cyjseagull pushed a commit that referenced this pull request Aug 11, 2020
MaggieNgWu pushed a commit that referenced this pull request Sep 27, 2020
cyjseagull pushed a commit that referenced this pull request Oct 12, 2020
cyjseagull pushed a commit that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants