Skip to content

update Dockerfile#95

Merged
JimmyShi22 merged 8 commits intoFISCO-BCOS:masterfrom
99Kies:patch-9
Mar 5, 2020
Merged

update Dockerfile#95
JimmyShi22 merged 8 commits intoFISCO-BCOS:masterfrom
99Kies:patch-9

Conversation

@99Kies
Copy link
Copy Markdown
Contributor

@99Kies 99Kies commented Feb 15, 2020

  1. 利用本地资源build 镜像 缩短时间
  2. 获取get_buildchain.sh 的url不稳定,更换获得build_chain.sh的方式
  3. 防止重复git clone

1. 利用本地资源build 镜像 缩短时间
2. 获取get_buildchain.sh 的url不稳定,更换获得build_chain.sh的方式
3. 防止重复git clone
@99Kies
Copy link
Copy Markdown
Contributor Author

99Kies commented Feb 15, 2020

这个https://raw.githubusercontent.com/FISCO-BCOS/FISCO-BCOS/master/tools/get_buildchain.sh在linux下 curl这个url 常常失败

@ghost
Copy link
Copy Markdown

ghost commented Feb 15, 2020

Warnings are found on analyzing the commit 09e3d04.

1 warning:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

update dockerfile
@99Kies 99Kies closed this Feb 15, 2020
@99Kies 99Kies reopened this Feb 15, 2020
Comment thread Dockerfile Outdated
curl -Ls https://raw.githubusercontent.com/FISCO-BCOS/FISCO-BCOS/master/tools/get_buildchain.sh > get_buildchain.sh && chmod u+x get_buildchain.sh && \
bash get_buildchain.sh && chmod u+x build_chain.sh && \
cd /python-sdk && \
curl -LO https://github.com/FISCO-BCOS/FISCO-BCOS/releases/download/`curl -s https://api.github.com/repos/FISCO-BCOS/FISCO-BCOS/releases | grep "\"v2\.[0-9]\.[0-9]\"" | sort -u | tail -n 1 | cut -d \" -f 4`/build_chain.sh && chmod u+x build_chain.sh && \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
curl -LO https://github.com/FISCO-BCOS/FISCO-BCOS/releases/download/`curl -s https://api.github.com/repos/FISCO-BCOS/FISCO-BCOS/releases | grep "\"v2\.[0-9]\.[0-9]\"" | sort -u | tail -n 1 | cut -d \" -f 4`/build_chain.sh && chmod u+x build_chain.sh && \
curl -LO https://github.com/FISCO-BCOS/FISCO-BCOS/releases/download/$(curl -s https://api.github.com/repos/FISCO-BCOS/FISCO-BCOS/releases | grep "\"v2\.[0-9]\.[0-9]\"" | sort -u | tail -n 1 | cut -d \" -f 4)/build_chain.sh && chmod u+x build_chain.sh && \

@JimmyShi22 JimmyShi22 merged commit 68c3f1e into FISCO-BCOS:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants