Spec enum example is invalid for optionalBoolean

[mjpt777]

The following example is in the spec and it does not pass schema validation as presence and nullValue are not allowed on enum:

<enum name="optionalBoolean" encodingType="uint8" presence="optional"
    nullValue="255" semanticType="Boolean">
    <validValue name="false">0</validValue>
    <validValue name="true">1</validValue>
</enum>

https://github.com/FIXTradingCommunity/fix-simple-binary-encoding/blob/master/v1-0-STANDARD/doc/02FieldEncoding.md

It would be helpful if all examples where tested for schema validation and with a reference implementation.

[donmendelson]

The Boolean enum example was changed in the v 2.0 RC 1 spec. Presence, semanticType and nullValue attributes moved to the field.

<enum name="booleanEnum" encodingType="uint8">
    <validValue name="false">0</validValue>
    <validValue name="true">1</validValue>
</enum>

<field type="requiredBoolean" name="SolicitedFlag" id="377" presence="required" semanticType="Boolean" />
<field type="optionalBoolean" name="SolicitedFlag" id="377" presence="optional" nullValue="255" semanticType="Boolean" />

[donmendelson]

The issue is correct that the example does not conform to the v 1.0 XSD. Version 1.0 is final in terms of features, but we may publish errata.

[kleihan]

Can we collect known errata items for SBE 1.0 somewhere in github where it is easy to find, i.e. not buried in a pull request? From there we can easily create and publish an errata version if we want to.

[donmendelson]

I created label "errata" to track such items. So far, this is the only one I'm aware of that was not caught before we published v1.0 standard.

[karypid]

What happens if the null value collides with one of the enumeration's valid values? Should this declared illegal and added to the list of Schema Validation checks?

Also, when an enum is defined inline within a composite, it is impossible to define it as optional. See point (3) in my question #84.