Skip to content

Conversation

@svdhoog
Copy link
Contributor

@svdhoog svdhoog commented Apr 12, 2017

The folder xparser/tests/test_mesgs contains 5 models that produce errors. See the readme.rd file in that folder for how to reproduce the tests. Each model folder contains the same script parse.sh that parses the model.xml file using the xparser in this repository's root (make sure the build first).

@mondus
Copy link
Contributor

mondus commented Apr 13, 2017

Should not be merged until a fix is created and tests pass.

@svdhoog
Copy link
Contributor Author

svdhoog commented Aug 30, 2017

Added the custom Makefile.templ file to the pull request (Issue #8).

@LuffyLuffy
Copy link

how to use the make.templ file when installation? after /.configure --prefix=/mnt/usr/my/gsl-2.4?

@svdhoog
Copy link
Contributor Author

svdhoog commented Dec 20, 2017

@LuffyLuffy, I think the answer is described here: #8.
Edit Makefile.templ:

LIBMBOARD_DIR=/mnt/usr/my/gsl-2.4

Although I would advise against installing GSL and Libmboard in the same folder, as it looks like you are doing (gsl-2.4 is where you installed GSL I suppose).

…es at run-time when writing output to xml files
@mondus
Copy link
Contributor

mondus commented Jan 4, 2018

@svdhoog Looks great. Happy for this to be merged.

@svdhoog
Copy link
Contributor Author

svdhoog commented Jan 4, 2018

@mondus Great, thanks! But please note I was unable to find a way to make 2 separate pull requests, so these are 5 commits. And I assume the "happy to merge" only refers to the last 2 commits in this pull request (commit 4/5 for GSL in non-standard locations and commit 5/5 on asserts for extreme values). Since commits 1-3 refer to the test models for messages, which have not yet been fixed/attended to as far as I know.

…es in call to setter function (and comment out in write_Agentname_agent)
@svdhoog
Copy link
Contributor Author

svdhoog commented Jan 6, 2018

@mondus Note new commit 0cc5e6f. This does the assert checking in the setter functions, and comments out the assert in the write-out functions write_Agentname_name(). Reason for this is two-fold: more granular checks, and the assert at write-out may cause problems.

@mondus
Copy link
Contributor

mondus commented Jan 10, 2018

Hi @svdhoog . Just to be clear. If we merge then this will include two commits for GSL and extreme values and ad some test models which currently cause a problem which needs fixing? If so then happy to merge and create a bug for the failing models.

@svdhoog
Copy link
Contributor Author

svdhoog commented Jan 10, 2018

@mondus Yes, that's all included. I also updated the comment above a bit to reflect the value-checking for the setter functions as well. Would be good if this comment somehow could be carried over to the documentation.

@svdhoog
Copy link
Contributor Author

svdhoog commented Jan 17, 2018

Unittests for function conditions (64 unittests)

This unittest suite consists of tests for function conditions. Tested are pairs of one time-condition and one memory-condition, using one logical operator (AND, OR), and the NOT operator.

A description of the tests is in xparser/tests/test_conditions/docs/tests_conditions.tex.

The folder xparser/tests/test_conditions/models contains 16 models in 4 variations (a-d). See the readme.rd file on how to reproduce the tests. All 64 tests pass.

@mondus mondus merged commit 658e90a into FLAME-HPC:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants