Skip to content

Conversation

@Ahmad8864
Copy link
Contributor

@Ahmad8864 Ahmad8864 commented Feb 25, 2025

Summary

This PR introduces a new boxplot function in the visualization module. The function calculates summary statistics and uses those to create a Plotly boxplot. The function is designed to handle various configurations, including different layers, annotations, and log scale transformations.

Changes

  • New boxplot Function:

    • Computes summary statistics (whislo, q1, med, mean, q3, whishi, fliers) for the specified features.
    • Supports optional annotations and layers.
    • Handles log scale transformations and outlier configurations (all, downsample, none).
    • Returns either a Plotly figure or an image based on the interactive parameter.
    • Optionally returns the computed metrics if return_metrics is set to True.
  • Updated boxplot unit tests

    • Changed boxplot unit tests to ensure consistency between implementations and new features
  • Integration in SPAC_Shiny/app.py

    • Updated the spac_Boxplot_1 and spac_Boxplot_2 functions to use the new boxplot function.
    • Added logic to handle the different figure types and returned metrics

Suggested Future Changes

  • Break long legend strings using <br> to prevent chart from being shrunk
  • Increase resolution of non-interactive plot using pio.to_image scale param

REMINDER: Change back the workflow image_to_use once kaleido is added

@Ahmad8864 Ahmad8864 changed the base branch from main to dev February 25, 2025 22:23
@Ahmad8864
Copy link
Contributor Author

I can't create a new branch, so I've chosen the target branch as dev

@georgezakinih georgezakinih merged commit 0896f69 into FNLCR-DMAP:dev Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants