feat(setup_analysis_template): add setup_analysis_template function a…#362
Merged
fangliu117 merged 2 commits intodevfrom Jul 28, 2025
Merged
feat(setup_analysis_template): add setup_analysis_template function a…#362fangliu117 merged 2 commits intodevfrom
fangliu117 merged 2 commits intodevfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts the NIDAP Setup Analysis template to a platform-agnostic SPAC template function. The main purpose is to provide a reusable template for setting up single-cell analysis with configurable parameters.
Key changes include:
- Implementation of a new
setup_analysis_template.pymodule withrun_from_jsonfunction - Comprehensive unit test suite covering various input scenarios and edge cases
- Support for both file-based and in-memory workflows through the
save_resultsparameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/spac/templates/setup_analysis_template.py |
Main template implementation with parameter parsing, data ingestion, and output handling |
tests/templates/test_setup_analysis_template.py |
Complete unit test suite with mocking, edge case testing, and validation scenarios |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd unit tests
Convert NIDAP Setup Analysis template to platform-agnostic SPAC template function