feat(arcsinh_normalization_template): add arcsinh_normalization_templ…#366
Merged
fangliu117 merged 2 commits intodevfrom Aug 2, 2025
Merged
feat(arcsinh_normalization_template): add arcsinh_normalization_templ…#366fangliu117 merged 2 commits intodevfrom
fangliu117 merged 2 commits intodevfrom
Conversation
…ate function and unit tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new arcsinh normalization template function with comprehensive unit tests, implementing platform-agnostic functionality converted from NIDAP.
- Adds
arcsinh_normalization_template.pywith JSON parameter parsing and data transformation capabilities - Implements comprehensive unit tests covering I/O workflows, parameter validation, and function calls
- Provides CLI interface and flexible save/return options for both file-based and in-memory workflows
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/spac/templates/arcsinh_normalization_template.py |
Main template implementation with JSON parameter parsing, data transformation, and flexible output handling |
tests/templates/test_arcsinh_normalization_template.py |
Comprehensive test suite with mock data generation, I/O testing, and parameter validation |
Comments suppressed due to low confidence (1)
src/spac/templates/arcsinh_normalization_template.py:101
- Missing closing parenthesis for the arcsinh_transformation function call. The function call starting at line 93 is missing its closing parenthesis.
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ate function and unit tests