Skip to content

feat(arcsinh_normalization_template): add arcsinh_normalization_templ…#366

Merged
fangliu117 merged 2 commits intodevfrom
template_arcsinh_normalization
Aug 2, 2025
Merged

feat(arcsinh_normalization_template): add arcsinh_normalization_templ…#366
fangliu117 merged 2 commits intodevfrom
template_arcsinh_normalization

Conversation

@fangliu117
Copy link
Collaborator

…ate function and unit tests

Copilot AI review requested due to automatic review settings August 2, 2025 12:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new arcsinh normalization template function with comprehensive unit tests, implementing platform-agnostic functionality converted from NIDAP.

  • Adds arcsinh_normalization_template.py with JSON parameter parsing and data transformation capabilities
  • Implements comprehensive unit tests covering I/O workflows, parameter validation, and function calls
  • Provides CLI interface and flexible save/return options for both file-based and in-memory workflows

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/spac/templates/arcsinh_normalization_template.py Main template implementation with JSON parameter parsing, data transformation, and flexible output handling
tests/templates/test_arcsinh_normalization_template.py Comprehensive test suite with mock data generation, I/O testing, and parameter validation
Comments suppressed due to low confidence (1)

src/spac/templates/arcsinh_normalization_template.py:101

  • Missing closing parenthesis for the arcsinh_transformation function call. The function call starting at line 93 is missing its closing parenthesis.
        )

@fangliu117 fangliu117 merged commit 78cc5a9 into dev Aug 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants