Skip to content

feat(sankey_plot_template): add sankey_plot_template function and uni…#378

Merged
fangliu117 merged 2 commits intodevfrom
template_sankey_plot
Aug 3, 2025
Merged

feat(sankey_plot_template): add sankey_plot_template function and uni…#378
fangliu117 merged 2 commits intodevfrom
template_sankey_plot

Conversation

@fangliu117
Copy link
Collaborator

…t tests

Copilot AI review requested due to automatic review settings August 3, 2025 04:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Sankey plot template function with comprehensive unit tests. The implementation converts an existing NIDAP template to a platform-agnostic Python function that creates Sankey diagrams from single-cell analysis data.

  • Adds sankey_plot_template.py with run_from_json function for creating Sankey plots from AnnData objects
  • Implements comprehensive test suite with mocking for I/O operations and plot generation
  • Supports multiple output formats (static PNG, interactive HTML) with configurable parameters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/spac/templates/sankey_plot_template.py Main template implementation with JSON parameter parsing and multi-format plot output
tests/templates/test_sankey_plot_template.py Comprehensive unit tests with mocked data and I/O operations
Comments suppressed due to low confidence (1)

src/spac/templates/sankey_plot_template.py:113

  • The variable name 'static' is confusing as it refers to a matplotlib figure object, not a static value. Consider renaming to 'fig_static' or 'matplotlib_fig' for clarity.
    static, axs = plt.subplots(1, 1, figsize=(width_num, height_num), dpi=dpi) 

@fangliu117 fangliu117 merged commit f3e5864 into dev Aug 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants