feat(sankey_plot_template): add sankey_plot_template function and uni…#378
Merged
fangliu117 merged 2 commits intodevfrom Aug 3, 2025
Merged
feat(sankey_plot_template): add sankey_plot_template function and uni…#378fangliu117 merged 2 commits intodevfrom
fangliu117 merged 2 commits intodevfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Sankey plot template function with comprehensive unit tests. The implementation converts an existing NIDAP template to a platform-agnostic Python function that creates Sankey diagrams from single-cell analysis data.
- Adds
sankey_plot_template.pywithrun_from_jsonfunction for creating Sankey plots from AnnData objects - Implements comprehensive test suite with mocking for I/O operations and plot generation
- Supports multiple output formats (static PNG, interactive HTML) with configurable parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/spac/templates/sankey_plot_template.py | Main template implementation with JSON parameter parsing and multi-format plot output |
| tests/templates/test_sankey_plot_template.py | Comprehensive unit tests with mocked data and I/O operations |
Comments suppressed due to low confidence (1)
src/spac/templates/sankey_plot_template.py:113
- The variable name 'static' is confusing as it refers to a matplotlib figure object, not a static value. Consider renaming to 'fig_static' or 'matplotlib_fig' for clarity.
static, axs = plt.subplots(1, 1, figsize=(width_num, height_num), dpi=dpi)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t tests