feat(interactive_spatial_plot_template): add interactive_spatial_plot…#382
Merged
fangliu117 merged 2 commits intodevfrom Aug 3, 2025
Merged
feat(interactive_spatial_plot_template): add interactive_spatial_plot…#382fangliu117 merged 2 commits intodevfrom
fangliu117 merged 2 commits intodevfrom
Conversation
…_template function and unit tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new interactive spatial plot template function to the SPAC library, enabling generation of interactive spatial visualizations with customizable parameters. The implementation maintains compatibility with existing NIDAP template functionality while providing platform-agnostic execution.
- Adds
interactive_spatial_plot_template.pywith configurable visualization parameters - Implements comprehensive unit tests covering I/O workflows, error validation, and function calls
- Provides both programmatic and CLI interfaces for template execution
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/spac/templates/interactive_spatial_plot_template.py |
Main template implementation with parameter parsing, visualization generation, and output handling |
tests/templates/test_interactive_spatial_plot_template.py |
Comprehensive test suite with mock data generation and workflow validation |
Comments suppressed due to low confidence (2)
src/spac/templates/interactive_spatial_plot_template.py:72
- Variable name 'Font_size' uses inconsistent capitalization. It should follow Python naming conventions and be 'font_size' to match other variables in the function.
Font_size = params.get("Font_Size", 12)
src/spac/templates/interactive_spatial_plot_template.py:125
- Using inconsistently named variable 'Font_size'. This should be 'font_size' to maintain consistent naming throughout the codebase.
font_size=Font_size,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_template function and unit tests