Skip to content

feat(visualize_nearest_neighbor_template): add visualize_nearest_neig…#385

Merged
fangliu117 merged 2 commits intodevfrom
template_visualize_nearest_neighbor
Aug 4, 2025
Merged

feat(visualize_nearest_neighbor_template): add visualize_nearest_neig…#385
fangliu117 merged 2 commits intodevfrom
template_visualize_nearest_neighbor

Conversation

@fangliu117
Copy link
Collaborator

…hbor_template function and unit tests

Copilot AI review requested due to automatic review settings August 4, 2025 02:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new visualize_nearest_neighbor_template function that provides a platform-agnostic implementation of NIDAP template functionality for visualizing nearest neighbor distance distributions. The template includes comprehensive parameter handling, figure customization, and output options.

  • Implements a complete template function with JSON parameter parsing and flexible output handling
  • Adds comprehensive unit tests covering I/O workflows, error validation, and function calls
  • Provides both file-based and in-memory workflow support with appropriate return types

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/spac/templates/visualize_nearest_neighbor_template.py Main template implementation with parameter parsing, visualization logic, and output handling
tests/templates/test_visualize_nearest_neighbor_template.py Comprehensive unit tests including mock data creation and workflow validation
Comments suppressed due to low confidence (1)

tests/templates/test_visualize_nearest_neighbor_template.py:188

  • The error message test has double spaces between 'convert' and 'to'. This suggests the error message format may not be correctly tested - verify that the actual error message from text_to_value matches this exact format including spacing.
            "Error: can't convert  to integer. "

@fangliu117 fangliu117 merged commit f1c7eaf into dev Aug 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants