feat(append_annotation_template): add append_annotation_template func…#388
Merged
fangliu117 merged 1 commit intodevfrom Aug 4, 2025
Merged
feat(append_annotation_template): add append_annotation_template func…#388fangliu117 merged 1 commit intodevfrom
fangliu117 merged 1 commit intodevfrom
Conversation
…tion and unit tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new append_annotation_template function that converts a NIDAP template to a platform-agnostic format. The template allows users to append annotation key-value pairs to existing DataFrames with support for multiple input formats (CSV, pickle) and flexible output options.
Key changes:
- Added
append_annotation_template.pywith the mainrun_from_jsonfunction - Comprehensive unit test suite covering input/output scenarios, error handling, and edge cases
- Support for DataFrame, CSV, and pickle input formats with appropriate error handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/spac/templates/append_annotation_template.py |
Core template implementation with JSON parameter parsing, multi-format data loading, and annotation appending |
tests/templates/test_append_annotation_template.py |
Comprehensive test suite covering functionality, error cases, and input format validation |
Comments suppressed due to low confidence (1)
tests/templates/test_append_annotation_template.py:178
- The test expects the error message to list
.csv, .pickle, .pklbut the actual code supports.pextension as well. This test will fail if the error message is corrected to include all supported formats.
self.assertIn("Supported formats: .csv, .pickle, .pkl",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion and unit tests