feat(normalize_batch_template): add normalize_batch_template function…#397
Merged
fangliu117 merged 2 commits intodevfrom Aug 4, 2025
Merged
feat(normalize_batch_template): add normalize_batch_template function…#397fangliu117 merged 2 commits intodevfrom
fangliu117 merged 2 commits intodevfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new normalize_batch_template function to the SPAC package, providing platform-agnostic batch normalization functionality converted from NIDAP. The implementation includes comprehensive unit tests and follows the established template pattern.
- Adds a new normalize_batch_template module with run_from_json function for batch normalization workflows
- Implements comprehensive unit tests covering various I/O scenarios and parameter configurations
- Provides CLI interface and flexible save/return options for different workflow needs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/spac/templates/normalize_batch_template.py | Main template implementation with batch normalization logic and parameter handling |
| tests/templates/test_normalize_batch_template.py | Comprehensive unit tests covering I/O workflows, parameter validation, and function calls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and unit tests