Enhanced network detection in installer#434
Enhanced network detection in installer#434bellegarde-c wants to merge 1 commit intoFOGProject:masterfrom
Conversation
Many enterprise networks disallow ping and direct HTTP(s) connections. Rework checkInternetConnection() to check DNS issues and then HTTP issues.
mastacontrola
left a comment
There was a problem hiding this comment.
Hello @bellegarde-c
I hope you're doing well, and sorry I haven't gotten back sooner.
There's a few things about this change that I'm a little confused about.
- The
$dns_commandis configured but then never used. - I tried a site I knew didn't exist and it showed host and nslookup with a non-zero return. Maybe it existed at one point and no longer does? I, for now, have just used getent as I believe this is more versatile.
I also changed the output so the testing can be more verbose.
I added the changes into the working-1.6 branch.
I would ask you to review and make changes accordingly and instead of sending to the master please place the changes into dev-branch (Master is our release branch so we don't touch this branch until release is ready to go live)
Thank you,
|
Yes, I saw you already changed the code in dev branch just after sending this. Will report any issue and send you merge request next time I update. regards, |
|
@bellegarde-c @mastacontrola The changes were added to the |
Many enterprise networks disallow ping and direct HTTP(s) connections.
Rework checkInternetConnection() to check DNS issues and then HTTP issues.