Make sequential snapin execution opt-in by default#826
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add sequential execution with stop-on-failure and logging
Add ordered snapin queues with optional abort-on-failure and failure-context logging
Jun 14, 2026
Copilot
AI
changed the title
Add ordered snapin queues with optional abort-on-failure and failure-context logging
Make sequential snapin execution opt-in by default
Jun 14, 2026
mastacontrola
added a commit
that referenced
this pull request
Jun 14, 2026
The sequential-snapin feature (#824/#826) added the abort-on-failure and ordering plumbing but two gaps remained: - FOG_SCHEMA was never bumped, so the migration adding sjAbortOnFail / stSequence never ran and the new code INSERTed against missing columns. - There was no UI to actually set the run order; stSequence was only ever auto-derived from association order. This adds real per-host ordering: - schema: add snapinAssoc.saSequence (folded into migration 294) and bump FOG_SCHEMA to 294 so the snapin migration applies on upgrade. - SnapinAssociation: expose the sequence field. - Host: loadSnapins() orders by sequence; addSnapin() appends new snapins after existing ones; new setSnapinOrder() persists a chosen order. - Group: tasking reads each member host's snapins in sequence order. - Host page: a "Snapin Run Order" panel (up/down + Save) on the Snapins tab, backed by a getSnapinOrderList endpoint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequential snapin execution was being applied by default, but this behavior should remain off for the new snapin ordering feature unless explicitly enabled. This keeps existing multi-snapin behavior intact while preserving ordered execution for opt-in sequential runs.
Behavior change
abortOnFail/ sequential tasking flag.Sequential execution path
Implementation
SnapinClientto conditionally break after the first queued snapin only when sequential mode is enabled.