fix: support HTTP middleware metadata instances#130
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@lisiqi1983 Are you done with this PR so that I can review or is anything left? |
|
Thanks, this is ready for review now. I marked it ready and the verification steps are listed in the PR body. |
VikramAditya33
left a comment
There was a problem hiding this comment.
Thanks for the PR, the instance resolution logic and tests look alright. I've left an inline comment for a fix please take a look and also comment under the issue so that I can assign this issue to you.
VikramAditya33
left a comment
There was a problem hiding this comment.
LGTM, Thank you. Could you please squash your commits into one?
623a2fa to
bf8c769
Compare
|
Thanks, done — I squashed the PR down to a single commit while keeping the same tested changes. |
|
Thank you LGTM |
Summary
ModuleReffor class providersFixes #128
Verification
npm test -- --runInBand src/http/routing/route-registry-middleware.spec.tsnpx tsc -p tsconfig.build.json --noEmitnpx eslint src/http/routing/route-registry.ts src/http/routing/route-registry-middleware.spec.tsnpx prettier --check src/http/routing/route-registry.ts src/http/routing/route-registry-middleware.spec.tsgit diff --check -- src/http/routing/route-registry.ts src/http/routing/route-registry-middleware.spec.tsSummary by CodeRabbit