Skip to content

fix: avoid duplicate content-length on empty responses#148

Merged
VikramAditya33 merged 1 commit into
FOSSFORGE:mainfrom
MukundaKatta:codex/fix-empty-content-length-send
May 15, 2026
Merged

fix: avoid duplicate content-length on empty responses#148
VikramAditya33 merged 1 commit into
FOSSFORGE:mainfrom
MukundaKatta:codex/fix-empty-content-length-send

Conversation

@MukundaKatta
Copy link
Copy Markdown
Contributor

Closes #147

Summary

  • route empty responses with a tracked numeric content-length through endWithoutBody()
  • reuse the same ending helper for the immediate and backpressure retry paths
  • add a regression test for send() with a custom content-length and no body

Verification

  • npm test -- --runTestsByPath src/http/core/response.spec.ts
  • npm run build
  • npm run lint -- --quiet
  • git diff --check

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8a229fcc-743c-4967-bd95-ca7ab18bdbea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VikramAditya33 VikramAditya33 self-requested a review May 15, 2026 16:18
Copy link
Copy Markdown
Collaborator

@VikramAditya33 VikramAditya33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@VikramAditya33 VikramAditya33 merged commit 9997339 into FOSSFORGE:main May 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Content-Length headers crash

2 participants