fix: suppress false-positive ERROR log on client-abort in handleException#165
Merged
VikramAditya33 merged 1 commit intoMay 18, 2026
Merged
Conversation
…tion When a client disconnects mid-request, BodyParser rejects with "Connection aborted". RouteRegistry.executeHandler() catches this and calls handleException(), which was logging it as an unhandled server error and attempting a 500 response (which UwsResponse silently dropped because res.aborted was already true). A client disconnect is an expected network event, not a server fault. Fix: add an early-return guard at the top of handleException() that silently exits when res.isAborted is set or the error message is "Connection aborted", matching the pattern already used throughout the rest of the file for the aborted state. Adds a regression test that verifies logger.error is NOT called for Connection aborted errors. Closes FOSSFORGE#163 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a client disconnects mid-request,
BodyParserrejects with"Connection aborted".RouteRegistry.executeHandler()catches this and callshandleException(), which was logging it as an unhandled server error:Then it tried to send a 500 response, which
UwsResponse.send()silently dropped becausethis.abortedwas alreadytrue. So the log was pure noise — no response was sent, no crash occurred, nothing needed to be "handled."Fix
Add an early-return guard at the top of
handleException():This matches the pattern already used throughout the rest of the file (e.g. lines 279, 322–325, 373, 956, 967) for the aborted state.
Test
Added a regression test to
route-registry.spec.tsthat verifieslogger.erroris not called when the handler rejects with"Connection aborted".All 948 existing tests still pass.
Closes #163