fix: preserve body size limit error in fast-abort mode#198
Open
wahajahmed010 wants to merge 1 commit into
Open
fix: preserve body size limit error in fast-abort mode#198wahajahmed010 wants to merge 1 commit into
wahajahmed010 wants to merge 1 commit into
Conversation
When processDecompressedChunk hits maxBodySize in fastAbort mode, the stream was not explicitly destroyed and the original Body size limit exceeded error was overwritten by Connection aborted when the onAborted callback fired. Changes: - Set this.abortError before calling uwsRes.close() in the size limit path so the original error is preserved - Guard abortError assignment in onAborted to only set it when not already set, preventing overwrite of the real error Fixes FOSSFORGE#186
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #186 — When
processDecompressedChunkhitsmaxBodySizeinfastAbortmode, the originalBody size limit exceedederror was being overwritten byConnection abortedwhen theonAbortedcallback fired.Problem
onChunk),uwsRes.close()was called without first settingthis.abortError, so whenonAbortedfired, it unconditionally overwrote the error withConnection abortedclose()does not triggeronAborted, pending promises could hang foreverChanges
this.abortErrorto theBody size limit exceedederror before callinguwsRes.close()in the size limit paththis.abortErrorassignment inonAbortedto only set it when not already set:Testing
should preserve original error when size limit exceeded before abortshould preserve original error even when onAborted overwrites would occurBoth tests verify that
buffer()rejects withBody size limit exceededeven afteronAbortedfires, notConnection aborted.