fix: critical streaming bugs for request and response streaming#65
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
uWestJS Benchmark Results
|
Three critical bugs prevented HTTP streaming from working: 1. Request streaming - Missing super.resume() caused connections to abort after first chunk. Fixed by calling both uwsRes.resume() and super.resume() to properly resume both uWS and Node.js Readable. 2. Binary content auto-parsing - Route registry eagerly parsed all content types including binary, preventing streaming. Fixed by skipping auto-parse for application/octet-stream and multipart. 3. Duplicate Content-Length - Manually setting header before tryEnd() which also sets it. Fixed by letting tryEnd() handle it automatically. Changes: - Fix resume()/pause() to handle both uWS and Node.js Readable - Skip auto-parsing for streaming content types - Remove manual Content-Length setting in stream()
3d99bac to
fe6d24b
Compare
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three critical bugs prevented HTTP streaming from working:
Request streaming - Missing
super.resume()caused connections to abort after first chunk. Fixed by calling bothuwsRes.resume()andsuper.resume()to properly resume both uWS and Node.js Readable. Fixes Critical Bug; Request Body Streaming Not Working #63Binary content
auto-parsing- Route registry eagerly parsed all content types including binary, preventing streaming. Fixed by skipping auto-parse forapplication/octet-streamandmultipart. Fixes Route Registry Prevents Streaming for Binary Content #62Duplicate Content-Length - Manually setting header before
tryEnd()which also sets it. Fixed by lettingtryEnd()handle it automatically. Fixes Duplicate Content-Length Header in Response Streaming #64Changes:
resume()/pause()to handle both uWS and Node.js Readableauto-parsingfor streaming content typesContent-Lengthsetting instream()Summary by CodeRabbit