Fix: misleading example in etagFn documentation#91
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
VikramAditya33
left a comment
There was a problem hiding this comment.
The example looks good to me, I've left a comment, take a look at it because I believe it kinda makes sense to me otherwise open for your view as well
|
Also CI prettier tests are failing, please take a look at those too |
8b2cc2a to
198e233
Compare
|
LGTM, Thank you, could you squash your commits into one? |
198e233 to
a418d7d
Compare
|
Squashed commits into one as requested. Thanks! |
|
Please link the issue in the PR description properly. |
etagFn documentation
|
LGTM, Thank you |
This PR fixes a misleading
etagFnexample in the documentation.The previous example referenced
fileContent, which is not available in the function signature and would result in a ReferenceError.Updated the example to use file metadata (
stat.sizeandstat.mtimeMs), which are actually available.Also clarified that
etagFnonly receivesfs.Statsand not file content.Fixes #77