Merged
Conversation
rhit-halseysh
approved these changes
Jan 22, 2026
rhit-halseysh
requested changes
Jan 29, 2026
| public class LEDs extends SubsystemBase { | ||
| private final LightsIO _io; | ||
| private final LightsIO _io; | ||
| private final CANdle _candle; |
Collaborator
There was a problem hiding this comment.
Very close to what we want, but I might not have told you the right type. If you look under src\main\java\frc\lib\W8\devices, what class might work here to run our animations
| } | ||
| public LEDs(LightsIO io) { | ||
| _io = io; | ||
| _candle = new CANdle(1, "rio"); |
Collaborator
There was a problem hiding this comment.
you shouldn't have to instantiate a new CANdle, it should be taken care of when we actually create the subsystem in robot container
| public Command runAnimation() { | ||
| return this.startEnd( | ||
| () -> _candle.setControl(LEDConstants.rainbowAnim.withSlot(0).withColor(LEDConstants.colorPaleBlue)), | ||
| () -> _candle.setControl(new SolidColor(0, 3).withColor(colorWheezerBlue)) |
Collaborator
There was a problem hiding this comment.
After you change out the mechanism, these will have to be updated. Make sure you run a build to catch any errors
rhit-halseysh
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please work ( or something like that ).