Updating ftc.py courtesy of @j5155, as well as fixing a past bug with datetime from a previous PR of mine#460
Conversation
To here, including the correct file structure for this bot Added ftcscout (much better ftc stats) to the ftc commands Fixed datetime in ftc.py Removed toa, since toa pulls from ftc-events anyways. Deleted the toa section from config generation in main.py Fixed /stats issue with datetime (different level import between dozer2 and here)
|
small nit but the reason why |
| e.add_field(name='Website', value=website or 'n/a') | ||
| e.add_field(name='Team Info Page', value=f'https://ftcscout.org/teams/{team_num}') | ||
|
|
||
| if sres.status != 404: |
There was a problem hiding this comment.
tbh i would separate out OPR information to a separate command (maybe %ftc opr). I don't think it really belongs in the general command (and could get kinda toxic really quickly)
There was a problem hiding this comment.
How will this become toxic?
Not sure how making it a dedicated command would help if so
This suggestion received overwhelming support in FTC discord (29 up 0 down), maybe discuss it there? You might be right I'm just not sure I understand what you mean
There was a problem hiding this comment.
This suggestion received overwhelming support in FTC discord (29 up 0 down), maybe discuss it there? You might be right I'm just not sure I understand what you mean
First off, you said it could happen, not be something that gets tacked onto every team's entry in the default command.
How will this become toxic?
Having OPR be something the bot pulls by default when calling %ftc could quickly become a way to invalidate takes that users make. It could indirectly become a way of saying "your opinion is invalid because your team is bad"
There was a problem hiding this comment.
Seems like the main concern is specifying where the data comes from (ftc-events/ftcscout) rather than toa (command-name related)
/toa is probably going to remain an alias for the /ftc team command due to how used it appears to be still.
Maybe we can keep the default OPR for now and get some feedback from the wider community, and adjust based off observations and usage?
|
Will try to address those issues tonight @guineawheek |
Fix changes from guineawheek
|
Believe the latest comments have been resolved via latest merge with this patch branch |
Seperate OPR command
|
OPR has been seperated out into it's own command, %ftc opr, aliased to %topr (alias broken in |
|
i think opr is fine separately |
returned top-level ftc opr
|
%topr and %ftc opr should now be up to date on this PR, as per @j5155's message |
|
This PR is ready to merge as far as my planned code changes go. |
7 participants
Merging changes from ftc-dozer2-0/Dozer2.0#13 to here, including the correct file structure for this bot Added ftcscout (much better ftc stats) to the ftc commands Fixed datetime in ftc.py
Removed toa, since toa pulls from ftc-events anyways. Deleted the toa section from config generation in main.py Fixed /stats issue with datetime (different level import between dozer2 and here)