Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
코멘트 부탁드립니다🙏
현재 App.js에 있는데 index.js로 옮겨야 하는지 궁금합니다.
2-1. +71 ~ +76에 알맞는 시맨틱 태그가 있을까요?
2-2. component를 더 나눠야 할지 고민입니다.
제일 작은 단위로 나눠야하고 재 사용성을 고려해야한다고 하는데 현 시점에서 재 사용을 하는 곳이 없어서.. :(
이 외에 다른 코멘트들도 모두 환영이에요🤞