-
Notifications
You must be signed in to change notification settings - Fork 0
Add B&W film development chart lookup system #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
10
commits into
main
Choose a base branch
from
copilot/add-chemistry-timing-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created DevelopmentChart model for B&W film dev timing lookup - Added Pydantic schemas for request/response validation - Implemented CRUD API endpoints at /api/dev-chart - Added lookup endpoint for finding dev times by film/developer/ISO - Included autocomplete endpoints for film stocks and developers - Database table auto-created on startup Co-authored-by: FSXAC <7558835+FSXAC@users.noreply.github.com>
- Created 18 test cases covering all CRUD operations - Test filtering by film stock, developer, and ISO rating - Test lookup functionality with exact matches and suggestions - Test autocomplete endpoints for films and developers - Test pagination and development time formatting - All tests passing successfully Co-authored-by: FSXAC <7558835+FSXAC@users.noreply.github.com>
- Created import_dev_chart.py script for bulk data import - Added dev_chart_seed.csv with 34 common film/developer combinations - Includes Ilford HP5+, FP4+, Delta series with various developers - Includes Kodak Tri-X, T-Max with D-76, HC-110, and T-Max Developer - Supports push/pull processing with multiple ISO ratings - Script handles MM:SS time format conversion - Tested import and API endpoints successfully Co-authored-by: FSXAC <7558835+FSXAC@users.noreply.github.com>
- Added Development Chart section to features - Documented all dev-chart API endpoints - Added CSV import instructions with format examples - Updated database tables list - Included information about 34 pre-seeded combinations Co-authored-by: FSXAC <7558835+FSXAC@users.noreply.github.com>
- Created examples/dev_chart_demo.py demonstrating API usage - Shows how to lookup dev times for specific combinations - Demonstrates push processing lookup (ISO 800) - Shows search and filtering by film stock - Includes helper for MM:SS to seconds conversion - Tested successfully with all examples working Co-authored-by: FSXAC <7558835+FSXAC@users.noreply.github.com>
… handling - Added database-level unique constraint to prevent duplicate entries - Fixed race condition by catching IntegrityError in create endpoint - Improved time parsing robustness (handles decimals, better error messages) - Removed duplicate time parsing logic in import script - Increased temperature limit to 100°C for broader process support - All tests passing with improved data integrity Co-authored-by: FSXAC <7558835+FSXAC@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add backend chart for tracking development timing and dilution
Add B&W film development chart lookup system
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a lookup table system for B&W film development timing, dilution, and temperature. C41 timing remains unchanged (roll-count based calculation).
Implementation
Database Model
DevelopmentCharttable with unique constraint on (film_stock, developer, iso_rating, dilution_ratio, temperature_celsius)API Endpoints (
/api/dev-chart)POST /lookup- Query by parameters, returns exact match or suggestionsGET /autocomplete/{films,developers}- Typeahead supportIntegrityErrorcatch-and-rollbackData Seeding
Usage
Testing
18 integration tests covering CRUD, lookup logic, filtering, pagination, and duplicate prevention.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.