-
Couldn't load subscription status.
- Fork 65
6-H #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6-H #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I only have few minor comments.
…e tested for correctness
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
…r both 6-H and 8-H NCCL
| #### Description | ||
| The purpose of this task is to use the Nsight System profiler to profile the starting point version non-Overlap MPI jacobi solver. The objective is to become familiar in navigating the GUI identify possible areas to overlap computation and communication. | ||
|
|
||
| - STEPS TO BE ADDED HERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I'm writing up some draft steps to be included here, but I think it makes sense to merge your PR first so that we can build on top of it.
| #ifdef SOLUTION | ||
| //TODO: | ||
| //Wait on both the top and bottom cuda events | ||
| //Wait on both the top and bottom cuda events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simongdg I think you need to check your editor to set tabs to 4 spaces wide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I do, sorry about that!
8-H_NCCL_NVSHMEM/NCCL/copy.mk
Outdated
| SOLUTIONDIR = ../../solutions/8-H_NCCL_NVSHMEM/NCCL | ||
|
|
||
| PROCESSFILES = jacobi.cu | ||
| COPYFILES = Makefile Instructions.ipynb Instructions.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not addressed.
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
You can ignore the 8-H stuff for now as I'm currently working on it