Skip to content

Conversation

@simongdg
Copy link
Collaborator

You can ignore the 8-H stuff for now as I'm currently working on it

Copy link
Collaborator

@jirikraus jirikraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I only have few minor comments.

@simongdg simongdg requested a review from jirikraus October 28, 2021 12:16
simongdg and others added 6 commits October 28, 2021 16:42
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
#### Description
The purpose of this task is to use the Nsight System profiler to profile the starting point version non-Overlap MPI jacobi solver. The objective is to become familiar in navigating the GUI identify possible areas to overlap computation and communication.

- STEPS TO BE ADDED HERE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'm writing up some draft steps to be included here, but I think it makes sense to merge your PR first so that we can build on top of it.

#ifdef SOLUTION
//TODO:
//Wait on both the top and bottom cuda events
//Wait on both the top and bottom cuda events
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indention.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simongdg I think you need to check your editor to set tabs to 4 spaces wide.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I do, sorry about that!

SOLUTIONDIR = ../../solutions/8-H_NCCL_NVSHMEM/NCCL

PROCESSFILES = jacobi.cu
COPYFILES = Makefile Instructions.ipynb Instructions.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not addressed.

simongdg and others added 7 commits October 29, 2021 11:07
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
simongdg and others added 3 commits October 29, 2021 11:11
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
Co-authored-by: Jiri Kraus <jkraus@nvidia.com>
@simongdg simongdg merged commit 1b34525 into FZJ-JSC:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants