Skip to content

Added a description of a known issue#491

Closed
BuelieR wants to merge 1 commit intoFabricMC:mainfrom
BuelieR:main
Closed

Added a description of a known issue#491
BuelieR wants to merge 1 commit intoFabricMC:mainfrom
BuelieR:main

Conversation

@BuelieR
Copy link
Copy Markdown

@BuelieR BuelieR commented Feb 10, 2026

Added a description of a known issue.
Using the official mapping makes it impossible to instantiate Identifier, but most tutorials nowadays are based on the YARN mapping and do not explain this in detail.

Added a description of a known issue.
@BuelieR BuelieR requested a review from a team as a code owner February 10, 2026 07:23
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 10, 2026

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit dd1d7a2
🔍 Latest deploy log https://app.netlify.com/projects/nimble-elf-d9d491/deploys/698adcf5ce3c68000831a7da
😎 Deploy Preview https://deploy-preview-491--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@its-miroma
Copy link
Copy Markdown
Member

What about Identifier.fromNamespaceAndPath()?

@ekulxam
Copy link
Copy Markdown
Contributor

ekulxam commented Feb 10, 2026

Identifier being abstract is not caused by mojmap. Mappings only change the name of the class, not the access modifiers or the function of the class. Additionally, the modern fabric docs are in mojmap and correctly use Identifier.fromNamespaceAndPath, which is Identifier.of in yarn. Notice how both methods perform the same function (although they have different names due to mappings), and Identifier is still abstract.

@its-miroma
Copy link
Copy Markdown
Member

its-miroma commented Feb 10, 2026

most tutorials nowadays are based on the YARN mapping

while that might have been true back in 2024, the docs now are fully migrated to Mojmap

@its-miroma its-miroma added the not-accepted This doesn't look right label Feb 10, 2026
@its-miroma its-miroma closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-accepted This doesn't look right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants