add name limit for fabric (#542)

[sanmesh-kakade]

(cherry picked from commit 2f46a05)

Description

Related issues

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• I have created feat/bugfix branch out of develop branch
• Code passes linting/formatting checks
• Changes to resources have been tested in our dev environments
• I have made corresponding changes to the documentation

Testing

Reviewer instructions

Summary by CodeRabbit

• Chores
  • Added name length limit configuration (20 characters) to ingress settings across AWS, Azure, and GCP cloud provider variants.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 91ca344f-d50f-430c-af2f-6b4b840e0572

📥 Commits

Reviewing files that changed from the base of the PR and between 3533638 and 9014a78.

📒 Files selected for processing (3)

• modules/ingress/nginx_gateway_fabric_legacy_aws/1.0/facets.yaml
• modules/ingress/nginx_gateway_fabric_legacy_azure/1.0/facets.yaml
• modules/ingress/nginx_gateway_fabric_legacy_gcp/1.0/facets.yaml

---

Walkthrough

A name_length_limit: 20 configuration field is added to the facets schema across three nginx gateway fabric legacy ingress module variants for AWS, Azure, and GCP cloud providers.

Changes

Cohort / File(s)	Summary
Nginx Gateway Fabric Legacy Facets Configuration modules/ingress/nginx_gateway_fabric_legacy_aws/1.0/facets.yaml, modules/ingress/nginx_gateway_fabric_legacy_azure/1.0/facets.yaml, modules/ingress/nginx_gateway_fabric_legacy_gcp/1.0/facets.yaml	Added top-level name_length_limit: 20 configuration field to facets schema for all three cloud provider variants.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only contains the PR template with unchecked checkboxes and empty sections, providing no actual content about changes, motivation, testing, or reviewers instructions.	Fill in the Description section with what was changed and why, select the Type of change, provide Testing details, and add Reviewer instructions.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'add name limit for fabric' directly summarizes the main change: adding a name_length_limit field across nginx_gateway_fabric modules.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch limit-fix-fabric-sync-master

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}